feat(ui): list certificates issued by ca by vlad-schur-external-sap · Pull Request #840 · cobaltcore-dev/aurora-dashboard

vlad-schur-external-sap · 2026-05-27T11:15:56Z

Summary

Implement certificate-table at pca/$pcaId route, where table is rendered with all required information

Changes Made

Created new route
Implemented CertificateList component with state indicators (error/no-data/loading etc.)

Related Issues

Issue 830: [Task](clavis): list certificates issued by CA #830

Testing Instructions

pnpm i
pnpm run test

Checklist

I have performed a self-review of my code.
I have commented my code, particularly in hard-to-understand areas.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.
I have made corresponding changes to the documentation (if applicable).
My changes generate no new warnings or errors.

Summary by CodeRabbit

New Features
- Added a certificates section to the PCA details page displaying all issued certificates with their IDs and certificate authority information.
Bug Fixes
- Fixed backend service configuration for certificate listing operations.
- Updated certificate schema validation to properly handle optional fields.
Localization
- Added English and German translations for certificate-related UI labels and messages.

Signed-off-by: Vladislav Schur <u.shchur@sap.com>

coderabbitai · 2026-05-27T11:16:09Z

📝 Walkthrough

Walkthrough

This PR introduces a complete PCA certificates list feature: a certificate table row component, container component with tRPC data fetching and state management, integration into the PCA details view, backend service routing change from clavis to pca, optional certificate schema fields, and English and German translation strings.

Changes

PCA Certificates List Feature

Layer / File(s)	Summary
Certificate Schema Optionality and Backend Service Routing `apps/aurora-portal/src/server/Services/types/pca.ts`, `apps/aurora-portal/src/server/Services/types/pca.test.ts`, `apps/aurora-portal/src/server/Services/routers/pcaRouter.ts`, `apps/aurora-portal/src/server/Services/routers/pcaRouter.test.ts`	`CertificateSchema` makes `certificate` and `configuration` optional; `pcaRouter.listCertificates` switches backend service selection from clavis to pca with updated test assertions and error messages.
Certificate Table Row Component `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/-table/PcaCertificatesTableRow.tsx`, `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/-table/PcaCertificatesTableRow.test.tsx`	Renders a table row with certificate authority ID, certificate ID, and a disabled Create Certificate menu item; test verifies rendering and menu state.
Certificates List Container `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaCertificatesListContainer.tsx`, `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaCertificatesListContainer.test.tsx`	Defines grid columns, queries certificates via tRPC with projectId and pcaId, renders loading/error/empty/data states with table rows and a disabled Issue Certificate button; tests cover all states and query parameter updates.
PCA Details View Integration `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaDetailsView.tsx`, `apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaDetailsView.test.tsx`	Details view imports and renders the certificates list container below existing content; test mocks the container and verifies presence in layout.
Translation Catalog `apps/aurora-portal/src/locales/en/messages.po`, `apps/aurora-portal/src/locales/de/messages.po`	English and German translation entries for Create Certificate, Issue End Entity Certificate, Loading, Empty, and Error state messages.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

cobaltcore-dev/aurora-dashboard#761: Adds the initial pcaRouter procedures including listCertificates that this PR builds UI and service selection upon.
cobaltcore-dev/aurora-dashboard#838: Introduces the PCA PcaDetailsView that this PR modifies to render the new certificates list section.
cobaltcore-dev/aurora-dashboard#770: Modifies the same PCA backend files (pcaRouter.ts, pca.ts) for certificate-authority certificate fetching and schema adjustments.

Suggested labels

aurora-portal, pca

Suggested reviewers

KirylSAP
mark-karnaukh-extern-sap
andypf

Poem

🐰 Certificates now list with pride,
From clavis moved to pca's side,
Optional fields let schemas breathe,
A table row and container weave,
Details page now shows them all! 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change: adding UI to list certificates issued by a certificate authority.
Description check	✅ Passed	The pull request description follows the template structure with all major sections completed: Summary, Changes Made, Related Issues, Testing Instructions, and Checklist with items marked complete.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch vlad-clavis-pca-cert-list-and-get-by-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/aurora-portal/src/locales/de/messages.po`:
- Around line 541-543: Several certificate-related msgid entries (e.g., "Create
Certificate") in the German PO file have empty msgstr values causing
untranslated UI; open the locales file and provide proper German translations
for each empty msgid (notably "Create Certificate" and the other ranges
mentioned), replacing the empty msgstr with the correct German text while
preserving PO syntax and encoding, and ensure you update msgstr for every
occurrence in the file so the new certificate UI displays translated strings.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3e9741c6-7579-45b9-ad1c-5c7507344cdd

📥 Commits

Reviewing files that changed from the base of the PR and between b027042 and 4d40c8f.

📒 Files selected for processing (14)

apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/-table/PcaCertificatesTableRow.test.tsx
apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/-table/PcaCertificatesTableRow.tsx
apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaCertificatesListContainer.test.tsx
apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaCertificatesListContainer.tsx
apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaDetailsView.test.tsx
apps/aurora-portal/src/client/routes/_auth/projects/$projectId/services/pca/$pcaId/-components/PcaDetailsView.tsx
apps/aurora-portal/src/locales/de/messages.po
apps/aurora-portal/src/locales/de/messages.ts
apps/aurora-portal/src/locales/en/messages.po
apps/aurora-portal/src/locales/en/messages.ts
apps/aurora-portal/src/server/Services/routers/pcaRouter.test.ts
apps/aurora-portal/src/server/Services/routers/pcaRouter.ts
apps/aurora-portal/src/server/Services/types/pca.test.ts
apps/aurora-portal/src/server/Services/types/pca.ts

Signed-off-by: Vladislav Schur <u.shchur@sap.com>

TilmanHaupt

all good, but this is off.

Also you can give the Create Certificate Authority Button into the ContentHeader

andypf

👍

feat(ui): list certificates issued by ca

4d40c8f

Signed-off-by: Vladislav Schur <u.shchur@sap.com>

vlad-schur-external-sap requested a review from a team as a code owner May 27, 2026 11:15

coderabbitai Bot reviewed May 27, 2026

View reviewed changes

Comment thread apps/aurora-portal/src/locales/de/messages.po

This was linked to issues May 27, 2026

[Task](clavis): list certificates issued by CA #830

Closed

[Task](clavis): get-by-id certificate issued by CA #832

Closed

vlad-schur-external-sap changed the title ~~feat(ui): list and get-by-id certificates issued by ca~~ feat(ui): list certificates issued by ca May 27, 2026

Merge branch 'main' into vlad-clavis-pca-cert-list-and-get-by-id

41f51b6

vlad-schur-external-sap self-assigned this May 27, 2026

vlad-schur-external-sap removed a link to an issue May 27, 2026

[Task](clavis): get-by-id certificate issued by CA #832

Closed

3 tasks

chore(docs): update doc as cert-by-ca implemented

b7885c0

Signed-off-by: Vladislav Schur <u.shchur@sap.com>

TilmanHaupt approved these changes May 27, 2026

View reviewed changes

andypf approved these changes May 27, 2026

View reviewed changes

vlad-schur-external-sap merged commit ff1f658 into main May 27, 2026
15 checks passed

vlad-schur-external-sap deleted the vlad-clavis-pca-cert-list-and-get-by-id branch May 27, 2026 14:48

coderabbitai Bot mentioned this pull request May 28, 2026

feat(ui): clavis pca certitificate get-by-id #844

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): list certificates issued by ca#840

feat(ui): list certificates issued by ca#840
vlad-schur-external-sap merged 3 commits into
mainfrom
vlad-clavis-pca-cert-list-and-get-by-id

vlad-schur-external-sap commented May 27, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 27, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

TilmanHaupt left a comment

Uh oh!

andypf left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vlad-schur-external-sap commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes Made

Related Issues

Testing Instructions

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TilmanHaupt left a comment

Choose a reason for hiding this comment

Uh oh!

andypf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vlad-schur-external-sap commented May 27, 2026 •

edited

Loading

coderabbitai Bot commented May 27, 2026 •

edited

Loading